#152 Spring Controller Code Review

Companies:

Sberbank

Themes:

SpringSpring BootCode Review

Find the errors:

public class AbstractController {

    protected AuditData auditData;
    }

    @RestController
    @Validated
    public class Controller extends AbstractController {

    private AuditService auditService;

    @PostMapping(path = "/**")
    public ResponseEntity<Response> createUser(@RequestBody @Valid ClientRq clientRq) {
        var client = clientRq.getClient();
        auditData.setClient(client);
        // Some code

        auditService.sendToAudit(auditData);
        // Some code

        return responseGenerator.generateResponse(clientRq);
    }

    @ExceptionHandler(Exception.class)
    public ResponseEntity<Response> handleError(
            HttpServletRequest request,
            Exception exception) {
        // Some code

        return responseGenerator.generateResponse();
    }
}

Question review

Mentor

Answer as you would in a real interview. I’ll ask follow-up questions, then compare your answer with the reference answer and show your accuracy as a %.

Sign in to start the dialogue The mentor keeps the context of the current question and your previous messages.