#502 Code Review of User Updates
Perform a code review:
public class UserUpdater {
@Autowired
private CompanyRepository companyRepository;
@Autowired
private UserRepository userRepository;
@Autowired
private RemoteUserInfoProvider remoteUserInfoProvider;
private Logger logger = Logger.getLogger(UserUpdater.class.getName());
public void fillUsersData() {
try {
companyRepository.findAll().forEach(company ->
updateUsersData(company.getUsers())
);
} catch (Exception e) {
logger.error("Error");
}
}
@Transactional
private void updateUsersData(
List<User> users
) {
// tx.begin
userRepository.lockUsers(users);
users.parallelStream().forEach(user -> {
UserInfo userInfo = remoteUserInfoProvider.getUserInfo(user.getId());
user.updateData(userRepository); // update user fields
userRepository.save(user);
}
);
}
}
Question review
Sign in to start the dialogue
The mentor keeps the context of the current question and your previous messages.
Sign in
Available with Premium
This is just one of the solutions available with Premium. And more:
- 250+ advanced lectures
- 1300+ practice exercises
- 500+ solutions to problems from real interviews
- Personalized Java Hub certificates
- Expanded access to the AI mentor