#526 Code Review of User Profile API

Companies:
Sberbank
Themes:
System DesignService CommunicationCode Review

What is wrong with this API?

What happens if we want to extend the profile by adding another document type? How should this be done?

GET  https://hr-test.ru/api/user-profile/8001

Auth Type: Bearer Token

Response
{
    "error": null,
    "data": {
        "id": 8001,
        "FIO": "John Doe",
        "seriesNumber": 4352 479893
    }
}

Question review

Mentor
Answer as you would in a real interview. I’ll ask follow-up questions, then compare your answer with the reference answer and show your accuracy as a %.
Sign in to start the dialogue The mentor keeps the context of the current question and your previous messages.
Sign in