#517 Code Review of Message Sending After Status Update

Companies:
Sberbank
Themes:
SpringTransactionsCode Review

Perform a code review:

@Service
@Component
class A {

    @Autowired
    private SomeRepository repo;

    @Autowired
    private MessageService mss;

    @Autowired
    private MessageRepository mssRepo;

    @Transactional
    void call(String id) {
        Optional<SomeEntity> entOpt = repo.findById(id)
        if (!entOpt.isEmpty()) {
          SomeEntity ent = entOpt.get();
          ent.setStatus("catched");
          repo.save(ent);
        }
        String msgId = mss.sendBroadcast(id+ " catched");
        mssRepo.save(new MessageEntity(msgId));
    }
}

Question review

Mentor
Answer as you would in a real interview. I’ll ask follow-up questions, then compare your answer with the reference answer and show your accuracy as a %.
Sign in to start the dialogue The mentor keeps the context of the current question and your previous messages.
Sign in