#192 Code Review of a Save Service with Notification Sending

Companies:
Sberbank
Themes:
SpringTransactionsCode Review

Perform a code review:

Java
@RequiredArgsConstructor
@Service
@Slf4j
public class ServiceA {

    @Value("${remote.service}")
    private String url;

    private final Repository repository;
    private final Mapper mapper;
    private final RestTemplate restTemplate;

    @Transactional
    public void save(Dto dto) {
        repository.save(mapper.convert(dto));
        log.info("Saved {}", dto);

        sendNotification(dto);
    }

    private void sendNotification(Dto dto) {
        log.info("Send notification {}", dto);
        restTemplate.postForObject(url, dto);
    }
}

Question review

Mentor
Answer as you would in a real interview. I’ll ask follow-up questions, then compare your answer with the reference answer and show your accuracy as a %.
Sign in to start the dialogue The mentor keeps the context of the current question and your previous messages.
Sign in