#192 Code Review of a Save Service with Notification Sending
Perform a code review:
@RequiredArgsConstructor
@Service
@Slf4j
public class ServiceA {
@Value("${remote.service}")
private String url;
private final Repository repository;
private final Mapper mapper;
private final RestTemplate restTemplate;
@Transactional
public void save(Dto dto) {
repository.save(mapper.convert(dto));
log.info("Saved {}", dto);
sendNotification(dto);
}
private void sendNotification(Dto dto) {
log.info("Send notification {}", dto);
restTemplate.postForObject(url, dto);
}
}Question review
Sign in to start the dialogue
The mentor keeps the context of the current question and your previous messages.
Sign in
Available with Premium
This is just one of the solutions available with Premium. And more:
- 250+ advanced lectures
- 1300+ practice exercises
- 500+ solutions to problems from real interviews
- Personalized Java Hub certificates
- Expanded access to the AI mentor